Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Looks like \Drupal\file\Plugin\migrate\process\d6\CckFile
is used for filefields and imagefields. For that we should handle alt and title.
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#13 | 2550755-13.patch | 2.88 KB | phenaproxima |
#11 | migrate_plugin_for-2550755-11.patch | 718 bytes | Nikolay Shapovalov |
#2 | 2550755.patch | 718 bytes | webflo |
Comments
Comment #2
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedComment #3
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedComment #4
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedComment #5
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedAnd found another strange thing in this class.
class CckFile extends Route
i think ProcessPluginBase makes more sense.Comment #7
phenaproximaWill you add a comment above these lines, explaining what's going on? The reason I ask is because the plugin is named CckFile and it's not immediately obvious that it's supposed to handle image fields as well.
I completely agree :) Will you add that to this patch?
Otherwise, looks perfect.
Comment #8
phenaproximaCckFile was refactored in #2549013: Remove load plugins, so this needs a re-roll.
Comment #11
Nikolay ShapovalovRerolled.
Comment #12
phenaproximaComment #13
phenaproximaWrote a test. Let's get this rinky-dink thing into core :)
Comment #14
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedThanks for following up on this, the test looks good.
Comment #15
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedComment #16
webchickSince these changes are self-contained against an experimental module, I believe that makes this eligible for commit during RC. Tagging.
Committed and pushed to 8.0.x. Thanks!
Comment #17
webchick