Problem/Motivation

Looks like \Drupal\file\Plugin\migrate\process\d6\CckFile is used for filefields and imagefields. For that we should handle alt and title.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webflo created an issue. See original summary.

webflo’s picture

webflo’s picture

Status: Active » Needs review
webflo’s picture

Title: Migrate plugin for files should handle alt and title attributes » Migrate plugin for filefields should handle alt and title attributes
webflo’s picture

And found another strange thing in this class. class CckFile extends Route i think ProcessPluginBase makes more sense.

phenaproxima queued 2: 2550755.patch for re-testing.

phenaproxima’s picture

Status: Needs review » Needs work
+++ b/core/modules/file/src/Plugin/migrate/process/d6/CckFile.php
+      'alt' => isset($options['alt']) ? $options['alt'] : '',
+      'title' => isset($options['title']) ? $options['title'] : '',

Will you add a comment above these lines, explaining what's going on? The reason I ask is because the plugin is named CckFile and it's not immediately obvious that it's supposed to handle image fields as well.

class CckFile extends Route i think ProcessPluginBase makes more sense.

I completely agree :) Will you add that to this patch?

Otherwise, looks perfect.

phenaproxima’s picture

Issue tags: +Needs reroll

CckFile was refactored in #2549013: Remove load plugins, so this needs a re-roll.

Status: Needs work » Needs review

zniki.ru queued 2: 2550755.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 2: 2550755.patch, failed testing.

Nikolay Shapovalov’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
718 bytes

Rerolled.

phenaproxima’s picture

Status: Needs review » Needs work
Issue tags: +Needs tests
phenaproxima’s picture

Wrote a test. Let's get this rinky-dink thing into core :)

webflo’s picture

Status: Needs review » Fixed

Thanks for following up on this, the test looks good.

webflo’s picture

Status: Fixed » Reviewed & tested by the community
webchick’s picture

Issue tags: +rc eligible

Since these changes are self-contained against an experimental module, I believe that makes this eligible for commit during RC. Tagging.

Committed and pushed to 8.0.x. Thanks!

webchick’s picture

Status: Reviewed & tested by the community » Fixed

  • webchick committed 5f5c6a4 on 8.0.x
    Issue #2550755 by webflo, phenaproxima, zniki.ru: Migrate plugin for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.