Problem/Motivation

The DB dump contains 'node' instead of '/node', so drupalGet('') on update path tests returns in a 404.

Proposed resolution

Fix it

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2550615-2.patch145.58 KBdawehner

Comments

dawehner created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new 2550615-2.patch145.58 KB 
"a:9:{s:4:"uuid";s:36:"92b62021-5c07-4770-8402-2ef9fe898c83";s:4:"name";s:12:"Site-Install";s:4:"mail";s:17:"admin@example.com";s:6:"slogan";s:0:"";s:4:"page";a:3:{i:403;s:0:"";i:404;s:0:"";s:5:"front";s:4:"node";}s:18:"admin_compact_mode";b:0;s:17:"weight_select_max";i:100;s:8:"langcode";s:2:"en";s:16:"default_langcode";s:2:"en";}"

"a:9:{s:4:"uuid";s:36:"92b62021-5c07-4770-8402-2ef9fe898c83";s:4:"name";s:12:"Site-Install";s:4:"mail";s:17:"admin@example.com";s:6:"slogan";s:0:"";s:4:"page";a:3:{i:403;s:0:"";i:404;s:0:"";s:5:"front";s:5:"/node";}s:18:"admin_compact_mode";b:0;s:17:"weight_select_max";i:100;s:8:"langcode";s:2:"en";s:16:"default_langcode";s:2:"en";}"
dawehner’s picture

dawehner
Primary language German
commented
Issue summary: View changes

.

dawehner’s picture

dawehner
Primary language German
commented
Priority: Normal » Critical
Status: Active » Needs review

This is blocking another critical

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
dawehner’s picture

dawehner
Primary language German
commented
Assigned: dawehner » Unassigned

Note: Sites at least could have used #2511962: Upgrade path for 2509300

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 580f335 and pushed to 8.0.x. Thanks!

  • alexpott committed 580f335 on 8.0.x 
    Issue #2550615 by dawehner: Update the DB dump to have a leading slash...
effulgentsia’s picture

effulgentsia commented

Is the db dump now based on a known commit hash? If so, what is it? If not, can we update to one (maybe beta-12?)?

catch’s picture

catch
he/him
Primary language English
commented

@effulgentsia it's not as far as I know. The database was committed, and then there have been small updates like this since as with the blocked issue, sometimes tests for issues providing update paths have required data that would have been upgraded for ones that didn't (because the dump pre-dates requiring hook_update_N()).

A completely fresh dump with beta 12 sounds good - although we'd want to explicitly check that any committed/pending updates in patches still run and are tested, otherwise might as well remove both them and the test coverage.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

This broke #2464427-152: Replace CacheablePluginInterface with CacheableDependencyInterface :(

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.