Problem/Motivation

TaxonomyController::getTitle() is not used, and can be mistaken for TaxonomyController::termTitle()

Proposed resolution

Remove TaxonomyController::getTitle()

Remaining tasks

Remove TaxonomyController::getTitle()

User interface changes

None

API changes

TaxonomyController::getTitle() removed

Data model changes

None

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because removed code is not currently used
Issue priority Normal because contrib authors could use the wrong method
Prioritized changes The main goal of this issue is removing unused code.
Disruption Potentially disruptive for contributed and custom modules because the removed method is public.
CommentFileSizeAuthor
#9 2550105-9.patch794 bytesEli-T
#2 2550105-2.patch842 bytesEli-T
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Eli-T created an issue. See original summary.

Eli-T’s picture

Eli-T
he/him
Primary language English
Location Manchester
CreditAttribution: Eli-T as a volunteer commented
Issue summary: View changes
Status: Active » Needs review
FileSize
2550105-2.patch842 bytes

Patch to remove TaxonomyController::getTitle().

Eli-T’s picture

Eli-T
he/him
Primary language English
Location Manchester
CreditAttribution: Eli-T as a volunteer commented
Issue summary: View changes
Eli-T’s picture

Eli-T
he/him
Primary language English
Location Manchester
CreditAttribution: Eli-T as a volunteer commented
Issue summary: View changes
Eli-T’s picture

Eli-T
he/him
Primary language English
Location Manchester
CreditAttribution: Eli-T as a volunteer commented
Assigned: Eli-T » Unassigned
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and commented

Do you mind checking whether this is already part of #2350509: Implement auto-route generation for all core entities and convert all of the core entities. ?

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr as a volunteer and at Happyculture commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

As seen on IRC that patch needs a tiny reroll as the comment juste after getTitle() changed.

Eli-T’s picture

Eli-T
he/him
Primary language English
Location Manchester
CreditAttribution: Eli-T as a volunteer commented
Assigned: Unassigned » Eli-T

@dawehner this method is still present after the latest patch from #2350509: Implement auto-route generation for all core entities and convert all of the core entities. is applied (#2350509-186: Implement auto-route generation for all core entities and convert all of the core entities.). So this issue is still relevant.

Eli-T’s picture

Eli-T
he/him
Primary language English
Location Manchester
CreditAttribution: Eli-T as a volunteer commented
Assigned: Eli-T » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
2550105-9.patch794 bytes

Rerolled

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr as a volunteer and at Happyculture commented
Status: Needs review » Reviewed & tested by the community 
+++ b/core/modules/taxonomy/src/Controller/TaxonomyController.php
@@ -16,20 +16,7 @@
-
+  ¶

That trailing spaces shouldn't be there but that can be fixed on commit.

Except that, it seems to be OK.
Thank you :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Yay dead code removed. Fixed whitespace error on commit. Committed 96d8f25 and pushed to 8.0.x. Thanks!

  • alexpott committed 96d8f25 on 8.0.x 
    Issue #2550105 by Eli-T: TaxonomyController::getTitle() is not used, and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.