TaxonomyController::getTitle() is not used, and can be mistaken for TaxonomyController::termTitle()
Remove TaxonomyController::getTitle()
Remove TaxonomyController::getTitle()
None
TaxonomyController::getTitle() removed
None
| Issue category | Task because removed code is not currently used |
|---|---|
| Issue priority | Normal because contrib authors could use the wrong method |
| Prioritized changes | The main goal of this issue is removing unused code. |
| Disruption | Potentially disruptive for contributed and custom modules because the removed method is public. |
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 2550105-9.patch | 794 bytes | eli-t |
| #2 | 2550105-2.patch | 842 bytes | eli-t |
Comments
Comment #2
eli-tPatch to remove TaxonomyController::getTitle().
Comment #3
eli-tComment #4
eli-tComment #5
eli-tComment #6
dawehnerDo you mind checking whether this is already part of #2350509: Implement auto-route generation for all core entities and convert all of the core entities. ?
Comment #7
duaelfrAs seen on IRC that patch needs a tiny reroll as the comment juste after getTitle() changed.
Comment #8
eli-t@dawehner this method is still present after the latest patch from #2350509: Implement auto-route generation for all core entities and convert all of the core entities. is applied (#2350509-186: Implement auto-route generation for all core entities and convert all of the core entities.). So this issue is still relevant.
Comment #9
eli-tRerolled
Comment #10
duaelfrThat trailing spaces shouldn't be there but that can be fixed on commit.
Except that, it seems to be OK.
Thank you :)
Comment #11
alexpottYay dead code removed. Fixed whitespace error on commit. Committed 96d8f25 and pushed to 8.0.x. Thanks!