Some tests are broken because of #2541800: Some config do not inherit from config_object, so locale_system_set_config_langcodes() results in schema errors, the error here is
diff.plugins:langcode variable type is string but applied schema class is Drupal\Core\Config\Schema\Mapping in Drupal\Core\Config\Testing\ConfigSchemaChecker->onConfigSave()
Replace type mapping with config_object where is needed and change type sequence of diff.plugins and change the structure
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | fix_config_schema-13.patch | 11.57 KB | giancarlosotelo |
| #11 | fix_config_schema-10.patch | 2.27 KB | giancarlosotelo |
| #5 | fix_schema_langcode_error-2549907-5.patch | 305 bytes | pravin ajaaz |
| #2 | fix_schema_langcode_error-2549907-2.patch | 540 bytes | pravin ajaaz |
Comments
Comment #2
pravin ajaaz commentedPatch based on it.
Comment #3
pravin ajaaz commentedComment #5
pravin ajaaz commentedComment #6
pravin ajaaz commentedComment #8
giancarlosotelo commentedI took a look on that and the error was quite different and a bit tricky, so sorry for that.
diff.plugins:langcode variable type is string but applied schema class is Drupal\Core\Config\Schema\Mapping in Drupal\Core\Config\Testing\ConfigSchemaChecker->onConfigSave()in
diff.plugins:we have to change the type to mapping and change the structure.Comment #9
giancarlosotelo commentedComment #10
giancarlosotelo commentedComment #11
giancarlosotelo commentedThis should work.
Comment #12
berdirThis doesn't work. Any kind of string could exist there, not just those. They are plugin ID's.
We must keep the sequence.
Instead, you need to move it one level down, so it that it becomes diff.plugins:field_types.$field_type, then you can keep type: sequence
Comment #13
giancarlosotelo commentedI move it one level down also in diff.plugins.yml (was necessary?) and small changes in the code to made this work.
Comment #14
berdirYes, this is the only way I see that can work here.
Comment #17
lhangea commentedWe have some failing tests which need to be fixed first it seems like.
Comment #18
berdirThere is more than one problem, neither will completely fix the tests. We need to commit something, then we can try to get it green in the other issues. Otherwise they block each other.
Comment #19
berdirWithout this issue, the test doesn't get past installing the default config and explodes before it even starts. This allows us to see the remaining test failures and is therefore a logical first step.
Comment #20
hampercm commentedI've verified on my local environment that once this patch and the patch from #2557979-14: SafeMarkup::placeholder() has been removed, SafeMarkup class has changed, update needed are both applied, the failing tests will pass on the latest 8.0.x.
Comment #22
lhangea commented