After hunting for a another bug, I stumbled on this.

In file
http://cgit.drupalcode.org/commerce_kickstart/tree/modules/commerce_kick...

There's a misnamed variable in line 101
should be display_descendants, but is display_decendants.

CommentFileSizeAuthor
#3 misnamed_variable-2549665-3.patch914 bytespravin ajaaz

Comments

snovak7 created an issue. See original summary.

snovak7’s picture

snovak7 commented
Issue tags: -drupal-commerce taxonomy +drupal-commerce, +taxonomy
pravin ajaaz’s picture

pravin ajaaz commented
Status: Active » Needs review
StatusFileSize
new misnamed_variable-2549665-3.patch914 bytes

Here is a patch for it

pravin ajaaz’s picture

pravin ajaaz commented
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented 
+++ b/modules/commerce_kickstart/commerce_kickstart_taxonomy/commerce_kickstart_taxonomy.module
@@ -98,7 +98,7 @@ function commerce_kickstart_taxonomy_term_path($vid, $tid) {
-      if (variable_get(_taxonomy_menu_build_variable('display_decendants', $vid), FALSE)) {
+      if (variable_get(_taxonomy_menu_build_variable('display_descendants', $vid), FALSE)) {

What are the side effects of this fix? As in do we need an upgrade hook to migrate values from the typo? Or would "it just work"?

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Issue tags: -drupal-commerce, -taxonomy +sprint

Adjusting tags.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

If PR passes committing: https://github.com/commerceguys/commerce_kickstart/pull/166

Issues in #5 are moot.

pravin ajaaz’s picture

pravin ajaaz commented

  • mglaman committed 8513d12 on 7.x-2.x 
    Merge pull request #166 from mglaman/2549665-misnamed-taxonomy-menu-var...
  • mglaman committed e8beb03 on 7.x-2.x authored by Pravin Ajaaz
    Issue #2549665 by Pravin Ajaaz: misnamed variable
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.