Problem/Motivation

According to #2205673: [META] Remove all @deprecated functions marked "remove before 8.0" this issue #2184907: Remove uses of drupal_add_http_header and related functions removes _drupal_set_preferred_header_name().

But that's not the case, so let's remove it.

Proposed resolution

Remove _drupal_set_preferred_header_name().

Remaining tasks

User interface changes

API changes

Data model changes

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task, because it is a removal of dead code
Issue priority Normal, because the impact is not high.
Disruption No discruption, it is an internal function. If someone called it before, its their own fault.
CommentFileSizeAuthor
#2 2549041_1.patch1.19 KBmile23

Comments

Mile23 created an issue. See original summary.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Active » Needs review
StatusFileSize
new 2549041_1.patch1.19 KB

Simple removal of the function and the only place it's used.

There should be a place to store a lookup table for common cases for headers; I'm not sure where that is.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#2477223: Refactor _drupal_add_html_head, drupal_get_html_head, _drupal_add_html_head_link into the attachments processor, remove from common.inc.
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

+1, deadcode--

dawehner’s picture

dawehner
Primary language German
commented
Category: Bug report » Task
Issue summary: View changes

Yeah less things to do. It is also an internal method ... so we can certainly drop it.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed e6479e4 and pushed to 8.0.x. Thanks!

  • alexpott committed e6479e4 on 8.0.x 
    Issue #2549041 by Mile23: Remove deprecated...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.