Write tests for the Update Manager downloading and applying updates for a module

Huh, InfoParserDynamic is quite a clever hack. :)

We desperately need test coverage for this stuff, and I don't see anything to complain about here, so RTBC. I'll commit this in a day or two if no concerns have been raised.

Previous result: FAILED: [[SimpleTest]]: [PHP 5.5 MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].

Re-testing. It was green a couple mins ago.

just nits, also wondered DRUPAL_ROOT usage

+++ b/core/lib/Drupal/Core/Updater/Module.php
@@ -18,26 +18,27 @@ class Module extends Updater implements UpdaterInterface {
     else {
-      $relative_path = $this->getRootDirectoryRelativePath();
+      // When installing a new module, prepend the requested root directory.
+      return $this->root . '/' . $this->getRootDirectoryRelativePath();
     }
-    return $this->root . '/' . $relative_path;

+++ b/core/lib/Drupal/Core/Updater/Theme.php
@@ -18,26 +18,27 @@ class Theme extends Updater implements UpdaterInterface {
     else {
-      $relative_path = $this->getRootDirectoryRelativePath();
+      // When installing a new theme, prepend the requested root directory.
+      return $this->root . '/' . $this->getRootDirectoryRelativePath();
     }
-    return $this->root . '/' . $relative_path;

else becomes unneeded

Sounds like that could use feedback from David. Though my inclination is to commit this anyway so we have the test coverage which we ever-so-desperately need, and then do any clean-ups in a follow-up issue.

That sounds good. Back to RTBC.

In another episode of "things I swore I committed weeks ago.." ;)

Committed and pushed to 8.0.x. Thanks!