PHP warnings/notice

When you don't set the Pushover api and user key you get PHP warnings and a notice on the user edit page

  • Warning: Invalid argument supplied for foreach() in form_select_options() (line 2784 of C:\wamp\www\dev\d701\htdocs\includes\form.inc).
  • Notice: Undefined index: sounds in pushover_sound_options() (line 305 of C:\wamp\www\dev\d701\htdocs\sites\all\modules\contrib\pushover\pushover.module).
  • Warning: array_merge(): Argument #2 is not an array in pushover_sound_options() (line 305 of C:\wamp\www\dev\d701\htdocs\sites\all\modules\contrib\pushover\pushover.module).

Pushover fields wrapper

Wrapped Pushover setting fields in a fieldset on the user edit page

Drupal code style

Fixed some Drupal code style issues

Pushover test button

Only show the button 'Send test notification' (on admin/config/services/pushover) if keys exists.

CommentFileSizeAuthor
#2 pushover-little-fixes-and-improvements-2548339-1.patch6.88 KBmvd81NL

Comments

mvd81NL created an issue. See original summary.

mvd81NL’s picture

mvd81NL commented
StatusFileSize
new pushover-little-fixes-and-improvements-2548339-1.patch6.88 KB
mvd81NL’s picture

mvd81NL commented
Status: Patch (to be ported) » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Closed (outdated)
Issue tags: -code cleanup, -PHP warnings (duplicate tag), -user interface improvements

I am closing this issue, which was created for a project version compatible with a Drupal release no longer supported. Feel free to re-open the issue, if it is still relevant for a project version compatible with a supported Drupal release.