Follow-up to #2533360: Upgrade to Symfony 2.7.2

Symfony 2.7.3 is now released.

Have a skim of the issue summary on #2454393: Upgrade to Symfony 2.6.5 for a better overview of why upgrading point releases is a good idea :).

This has couple of security fixes and updates to support PHP 7; changelog below, and hence marking as major.

Changelog changelog.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it is an external library upgrade.
Issue priority Major because this release contains security fixes.
Disruption Not disruptive.
CommentFileSizeAuthor
#8 upgrade_to_symfony_2_7_3-2548135-8.patch109.88 KBneclimdul
#6 upgrade_to_symfony_2_7_3-2548135-6.patch433.21 KBhussainweb
#4 upgrade_to_symfony_2_7_3-2548135-3.patch448.18 KBhussainweb
#4 interdiff-2-3.txt2.06 KBhussainweb
#2 upgrade_to_symfony_2_7_3-2548135-2.patch446.12 KBhussainweb

Comments

hussainweb created an issue. See original summary.

hussainweb’s picture

hussainweb
Primary language English
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new upgrade_to_symfony_2_7_3-2548135-2.patch446.12 KB

Upgrading to Symfony 2.7.3:

hw@d8:/var/www/d8task/core-[git 8.0.x] $ composer update symfony/*
Warning: This development build of composer is over 60 days old. It is recommended to update it by running "/usr/local/bin/composer self-update" to get the latest version.
Loading composer repositories with package information
Updating dependencies (including require-dev)
  - Removing symfony/class-loader (v2.7.2)
  - Installing symfony/class-loader (v2.7.3)
    Loading from cache

  - Removing symfony/console (v2.7.2)
  - Installing symfony/console (v2.7.3)
    Downloading: 100%

  - Removing symfony/css-selector (v2.7.2)
  - Installing symfony/css-selector (v2.7.3)
    Loading from cache

  - Removing symfony/dependency-injection (v2.7.2)
  - Installing symfony/dependency-injection (v2.7.3)
    Downloading: 100%

  - Removing symfony/debug (v2.7.2)
  - Installing symfony/debug (v2.7.3)
    Loading from cache

  - Removing symfony/http-foundation (v2.7.2)
  - Installing symfony/http-foundation (v2.7.3)
    Downloading: 100%

  - Removing symfony/event-dispatcher (v2.7.2)
  - Installing symfony/event-dispatcher (v2.7.3)
    Loading from cache

  - Removing symfony/http-kernel (v2.7.2)
  - Installing symfony/http-kernel (v2.7.3)
    Downloading: 100%

  - Removing symfony/routing (v2.7.2)
  - Installing symfony/routing (v2.7.3)
    Loading from cache

  - Removing symfony/serializer (v2.7.2)
  - Installing symfony/serializer (v2.7.3)
    Downloading: 100%

  - Removing symfony/translation (v2.7.2)
  - Installing symfony/translation (v2.7.3)
    Loading from cache

  - Removing symfony/validator (v2.7.2)
  - Installing symfony/validator (v2.7.3)
    Downloading: 100%

  - Removing symfony/process (v2.7.2)
  - Installing symfony/process (v2.7.3)
    Loading from cache

  - Removing symfony/yaml (v2.7.2)
  - Installing symfony/yaml (v2.7.3)
    Downloading: 100%

  - Removing symfony/dom-crawler (v2.7.2)
  - Installing symfony/dom-crawler (v2.7.3)
    Loading from cache

  - Removing symfony/browser-kit (v2.7.2)
  - Installing symfony/browser-kit (v2.7.3)
    Loading from cache

Writing lock file
Generating autoload files

Status: Needs review » Needs work

The last submitted patch, 2: upgrade_to_symfony_2_7_3-2548135-2.patch, failed testing.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2-3.txt2.06 KB
new upgrade_to_symfony_2_7_3-2548135-3.patch448.18 KB

I updated composer and ran an update again. There are some changes in autoloader as seen in interdiff.

Status: Needs review » Needs work

The last submitted patch, 4: upgrade_to_symfony_2_7_3-2548135-3.patch, failed testing.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Needs review
Parent issue: #2533360: Upgrade to Symfony 2.7.2 » #2400407: [meta] Ensure vendor (PHP) libraries are on latest stable release
StatusFileSize
new upgrade_to_symfony_2_7_3-2548135-6.patch433.21 KB

Removing hiddeninput.exe from the patch. That file causes the testbot to fail. See #2531798: Handle binary files in patches for more details on that issue. No interdiff, but I just removed the file, no other changes.

neclimdul’s picture

neclimdul
He/Him
commented 
+++ b/core/composer.lock
@@ -796,7 +796,7 @@
-                "url": "https://api.github.com/repos/guzzle/guzzle/zipball/1879fbe853b0c64d109e369c7aeff09849e62d1e",
+                "url": "https://api.github.com/repos/guzzle/guzzle/zipball/6692db3cda013e8357330243c33fe1838d0ea6f5",

??

neclimdul’s picture

neclimdul
He/Him
commented
StatusFileSize
new upgrade_to_symfony_2_7_3-2548135-8.patch109.88 KB

I guess something might be out of sync. did the same thing and got the same result. Patch didn't apply so here is a reroll.

neclimdul’s picture

neclimdul
He/Him
commented

for reviewers, the composer updates the information for a bunch of guzzle stuff but these are the only changes in the patch:

 core/composer.lock                                                   |   92 +--
 core/vendor/composer/installed.json                                  | 1152 +++++++++++++++---------------
 core/vendor/symfony/console/Input/ArgvInput.php                      |    4 +-
 core/vendor/symfony/console/Output/ConsoleOutput.php                 |   27 +-
 core/vendor/symfony/console/Question/ChoiceQuestion.php              |    2 +-
 core/vendor/symfony/console/Style/SymfonyStyle.php                   |    2 +-
 core/vendor/symfony/console/Tests/Helper/QuestionHelperTest.php      |    7 +
 core/vendor/symfony/dependency-injection/Loader/XmlFileLoader.php    |    5 +-
 .../dependency-injection/ParameterBag/ParameterBagInterface.php      |    7 +
 .../Tests/ParameterBag/FrozenParameterBagTest.php                    |    9 +
 core/vendor/symfony/http-foundation/Request.php                      |   55 +-
 core/vendor/symfony/http-foundation/Response.php                     |    2 +-
 core/vendor/symfony/http-foundation/Tests/RequestTest.php            |   21 +-
 core/vendor/symfony/http-kernel/Client.php                           |    2 +-
 core/vendor/symfony/http-kernel/EventListener/RouterListener.php     |    2 +-
 core/vendor/symfony/http-kernel/HttpCache/HttpCache.php              |   12 +-
 core/vendor/symfony/http-kernel/Kernel.php                           |    6 +-
 .../symfony/http-kernel/Tests/EventListener/RouterListenerTest.php   |   30 +
 core/vendor/symfony/http-kernel/composer.json                        |    2 +-
 core/vendor/symfony/serializer/Normalizer/AbstractNormalizer.php     |   16 +-
 core/vendor/symfony/serializer/Normalizer/GetSetMethodNormalizer.php |    3 +-
 .../serializer/Tests/Normalizer/GetSetMethodNormalizerTest.php       |   50 +-
 .../symfony/validator/Resources/translations/validators.ja.xlf       |    2 +-
 .../symfony/validator/Resources/translations/validators.th.xlf       |    2 +-
 core/vendor/symfony/yaml/Parser.php                                  |    4 +-
 core/vendor/symfony/yaml/Tests/ParserTest.php                        |   15 +
 26 files changed, 846 insertions(+), 685 deletions(-)
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

It is good to see that those updates are now more or less painless

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed bc7d4eb and pushed to 8.0.x. Thanks!

  • alexpott committed bc7d4eb on 8.0.x 
    Issue #2548135 by hussainweb, neclimdul: Upgrade to Symfony 2.7.3

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.