aria-label attribute was removed in #2173527: The Menu-Toolbar area should be refactored so that Tray items are nested in the same container as their associated parent Toolbar item. but it's necessary for accessibility as explained in #1800614-6: Improve the responsive toolbar accessibility.
Patch adds the attribute back using the logic of the original correct code.
| Comment | File | Size | Author |
|---|---|---|---|
| core-toolbar-tray-aria.patch | 1.91 KB | nod_ |
Comments
Comment #2
pp commentedIt is looking good for me. I tested it with Examples module with add language patch (https://www.drupal.org/node/2547627), because this issue appears when I run Examples module tests.
Comment #3
gábor hojtsyLooks good!
Comment #4
mortendk commentedlooks good :)
Comment #5
ianthomas_ukRTBC +1
The attribute was only removed in the first place because it was missed in a reroll, #2173527-18: The Menu-Toolbar area should be refactored so that Tray items are nested in the same container as their associated parent Toolbar item.
Comment #6
mile23aria-text is basically the only reliable way to test for the existence of the toolbar on the page. #2505711: Fix toolbar tests
RTBC +1.
Comment #7
nod_@Mile23 that doesn't sound right. A data attribute should be used ideally: data-drupal-selector #2509970: Apply and use data-drupal-selector consistently.
Comment #8
alexpottCommitted 5f79d63 and pushed to 8.0.x. Thanks!