aria-label attribute was removed in #2173527: The Menu-Toolbar area should be refactored so that Tray items are nested in the same container as their associated parent Toolbar item. but it's necessary for accessibility as explained in #1800614-6: Improve the responsive toolbar accessibility.

Patch adds the attribute back using the logic of the original correct code.

CommentFileSizeAuthor
core-toolbar-tray-aria.patch1.91 KBnod_

Comments

nod_ created an issue. See original summary.

pp’s picture

pp commented
Status: Needs review » Reviewed & tested by the community

It is looking good for me. I tested it with Examples module with add language patch (https://www.drupal.org/node/2547627), because this issue appears when I run Examples module tests.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Looks good!

mortendk’s picture

mortendk commented

looks good :)

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented

RTBC +1

The attribute was only removed in the first place because it was missed in a reroll, #2173527-18: The Menu-Toolbar area should be refactored so that Tray items are nested in the same container as their associated parent Toolbar item.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

aria-text is basically the only reliable way to test for the existence of the toolbar on the page. #2505711: Fix toolbar tests

RTBC +1.

nod_’s picture

nod_
Primary language French
Location Lille
commented

@Mile23 that doesn't sound right. A data attribute should be used ideally: data-drupal-selector #2509970: Apply and use data-drupal-selector consistently.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 5f79d63 and pushed to 8.0.x. Thanks!

  • alexpott committed 5f79d63 on 8.0.x 
    Issue #2548027 by nod_: Follow-up add back aria-label to toolbar tray

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.