Hi!
There is wrong return value in field_collection_views_views_default_views, so we notice about Undefined variable.

Notice: Undefined variable: views in function field_collection_views_views_default_views() (string 94 field_collection_views/views/field_collection_views.views_default.inc).

You need to add
$views [$view->name] = $view;
before return $views;

Regards,
Alex

CommentFileSizeAuthor
#6 field_collection_views-undefined-var-2548003-#5.patch1.02 KBrdatar

Comments

aaagepard created an issue. See original summary.

deanflory’s picture

deanflory commented

I too just got this error:

Notice: Undefined variable: views in field_collection_views_views_default_views() (line 94 of /.../sites/all/modules/field_collection_views/views/field_collection_views.views_default.inc).

webel’s picture

webel commented

Same error after upgrading a site from Drupal-7.30 to Drupal-7.39 and
Field Collection Views from 7.x-1.0-beta3+1-dev to 7.x-1.x-dev which gave:

Extension : field_collection_views
Project : field_collection_views
Version : 7.x-1.0-beta3+2-dev
Date : 2015-06-30

vm’s picture

vm commented

as pointed out in the issue summary:

placing $views [$view->name] = $view; before return $views; at he bottom of field_collection_views/views/field_collection_views.views_default.inc does seem to suppress the notice

summit’s picture

summit commented

hi,
i had the same thing upgrading to Drupal 7.40. Could someone make a patch please?
Thanks in advance!
Greetings, Martijn

rdatar’s picture

rdatar commented
StatusFileSize
new field_collection_views-undefined-var-2548003-#5.patch1.02 KB

Patch submitted for undefined variable issue. File name : field_collection_views-undefined-var-2548003-#5.patch

rdatar’s picture

rdatar commented
Assigned: Unassigned » rdatar
Status: Active » Needs review
summit’s picture

summit commented
Status: Needs review » Reviewed & tested by the community

Yes works! thanks.
greetings, Martijn

krknth’s picture

krknth commented

Yes, this patch fixing the Notice

  • krknth committed 2bbf6d5 on 7.x-1.x authored by rdatar 
    Issue #2548003 by rdatar, aaagepard, Summit, deanflory, VM, webel,...
neerajskydiver’s picture

neerajskydiver commented
Assigned: rdatar » Unassigned
Status: Reviewed & tested by the community » Fixed

Nice found, Thanks for patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.