$error in case of a views query exception

The fix looks good - anyway to test this?

Patch in #2 looks good to me, but wondering if this is slightly more readable.

Ups things happen, but now we will add test coverage so we actually gained something from breaking it :)

+++ b/core/modules/views/src/Plugin/views/query/Sql.php
@@ -1454,7 +1454,8 @@ function execute(ViewExecutable $view) {
+          $view_storage_label = $view->storage->label()[$view->storage->id()];
+          throw new DatabaseExceptionWrapper("Exception in {$view_storage_label}: {$e->getMessage()}");

I don't understand how the test is testing this code. Running the test without this code does not fail.

Please provide a TEST-Only with the test so we know that the test is actually failing without the fix.

Seems fine for me.
Next time remember to add the -test_only suffix in the name of the test only patch.

Yes, #4 was wrong, this is *not* php array access. It's about displaying this string: "My super view[my_super_view_id]".

1. +++ b/core/modules/views/src/Tests/Plugin/FilterExceptionTest.php
   @@ -0,0 +1,85 @@
   +/**
   + * Tests the exception filter.
   + *
   + * @group views
   + * @see test_exception_filter
   + */
   +class FilterExceptionTest extends PluginTestBase {
   

   I don't think that such a @see works? There is no function that it can point to, if anything, then we need to make it a reference to the plugin class?

   We are not testing the exception filter here. We are testing the views exception handling, so this should be called ViewsSqlExceptionTest or something like that. With a matching comment.

2. +++ b/core/modules/views/src/Tests/Plugin/FilterExceptionTest.php
   @@ -0,0 +1,85 @@
   +  public static $modules = array('views_ui');
   

   Do we really need the views_ui module to be enabled here?

3. +++ b/core/modules/views/src/Tests/Plugin/FilterExceptionTest.php
   @@ -0,0 +1,85 @@
   +  public function testFilterException() {
   

   This would then be called testSqlExeption()

4. +++ b/core/modules/views/src/Tests/Plugin/FilterExceptionTest.php
   @@ -0,0 +1,85 @@
   +    // Check that we can find the test filter plugin.
   +    $plugin = $this->container->get('plugin.manager.views.filter')->createInstance('test_exception_filter');
   +    $this->assertTrue($plugin instanceof FilterPluginException, 'Test filter exception plugin found.');
   

   Comment is outdated and I actually think those three lines are useless, we don't need to test that the plugin exists here.

5. +++ b/core/modules/views/src/Tests/Plugin/FilterExceptionTest.php
   @@ -0,0 +1,85 @@
   +    // Change the filtering.
   

   Add a more specific comment here, say that you add a filter that will result in an invalid query.

6. +++ b/core/modules/views/tests/modules/views_test_data/src/Plugin/views/filter/FilterExceptionTest.php
   @@ -0,0 +1,52 @@
   +   */
   +  protected function defineOptions() {
   +    $options = parent::defineOptions();
   +
   +    $options['test_enable'] = array('default' => TRUE);
   +    return $options;
   +  }
   +
   +  /**
   +   * Overrides Drupal\views\Plugin\views\row\RowPluginBase::buildOptionsForm().
   +   *
   +   * @return array
   +   */
   +  public function buildOptionsForm(&$form, FormStateInterface $form_state) {
   +    parent::buildOptionsForm($form, $form_state);
   +
   +    $form['test_enable'] = array(
   +      '#type' => 'checkbox',
   +      '#title' => $this->t('Controls whether the filter plugin should be active'),
   +      '#default_value' => $this->options['test_enable'],
   +    );
   +  }
   +
   

   We don't need all this.

It is great that we have test coverage now.

+++ b/core/modules/views/tests/modules/views_test_data/src/Plugin/views/filter/FilterExceptionTest.php
@@ -0,0 +1,24 @@
+  /**
+   * Overrides Drupal\views\Plugin\views\filter\FilterPluginBase::query().
+   */

We could just use {@inheritdoc}

Everything seems to work accordingly.

1. +++ b/core/modules/views/src/Tests/Plugin/ViewsSqlExceptionTest.php
   @@ -0,0 +1,73 @@
   +use Drupal\views_test_data\Plugin\views\filter\FilterExceptionTest as FilterPluginException;
   

   Not used.

2. +++ b/core/modules/views/src/Tests/Plugin/ViewsSqlExceptionTest.php
   @@ -0,0 +1,73 @@
   +
   +  public function testSqlExeption() {
   

   Typo and missing doc block.

3. +++ b/core/modules/views/tests/modules/views_test_data/src/Plugin/views/filter/FilterExceptionTest.php
   @@ -0,0 +1,24 @@
   +/**
   + * @ViewsFilter("test_exception_filter")
   + */
   

   Missing short class description.

Looks good now I think.

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed b833f73 and pushed to 8.0.x. Thanks!