Problem/Motivation

ckeditor_rebuild() was added to workaround the lack of renderPlain() and render contexts. Now that we have these, it could be moved to a helper for the insert/update hooks and not implement hook_rebuild() any more.

Proposed resolution

Remove it.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because pure clean-up.
Issue priority Normal because less complexity in ckeditor.module.
Disruption Zero disruption, pure internal change.
CommentFileSizeAuthor
#3 2546828-3.patch7.23 KBwim leers
#2 2546828-2.patch4.03 KBwim leers

Comments

catch created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
Related issues: +#2361681: drupal_render(): invert second argument ($is_recursive_call -> $is_root_call) => more strict, better DX/TX
StatusFileSize
new 2546828-2.patch4.03 KB

Quick patch. This basically reverts the CKEditor-related changes in #2361681: drupal_render(): invert second argument ($is_recursive_call -> $is_root_call) => more strict, better DX/TX.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new 2546828-3.patch7.23 KB

#2 is incomplete. Sorry about that.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Self-RTBC'ing since:

  1. this is just reverting to the old code
  2. I'm the sole maintainer for this component
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs review

This looks really good to me but self-rtbcing is not really right.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Yeah, sorry about that. Knowing the editor/ckeditor/quickedit issue queues though, nobody else will RTBC it.

But, this is not at all urgent. So let's just let it sit for a while :) It also is not an API change, so can even happen after 8.0.0.

Again, apologies. Won't happen again, not even for patches as trivial as this one.

fabianx’s picture

fabianx commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs beta evaluation

RTBC, but we need a beta-evaluation.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes
Issue tags: -Needs beta evaluation +Quick fix
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Removing unnecessary hooks and adding correct cache tags seems like a very good idea. Committed 3f31dbe and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

  • alexpott committed 3f31dbe on 8.0.x 
    Issue #2546828 by Wim Leers: Remove ckeditor_rebuild()

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.