Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
theme system
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
5 Aug 2015 at 17:14 UTC
Updated:
1 Sep 2015 at 08:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
alexpottHere's a patch.
Comment #3
alexpottComment #4
wim leersShould this be blocked on #2545972: Remove all code usages SafeMarkup::checkPlain() and rely more on Twig autoescaping?
These two lines are identical functionality-wise.
I'm assuming you're doing this solely to make the symmetry more apparent?
Comment #5
alexpottWell @xjm and others think #2545972: Remove all code usages SafeMarkup::checkPlain() and rely more on Twig autoescaping is wrong and tbh fixing this is more important.
Yep I think making the symmetry obvious makes reading the method simpler.
Comment #6
wim leersComment #7
catchSorry I'm postponing this on #2545972: Remove all code usages SafeMarkup::checkPlain() and rely more on Twig autoescaping, both wrappers are useful.
Comment #8
alexpottUsed Html::escape() not that it is not the exact opposite of Html::decodeEntities() but we have good test coverage around Xss and UrlHelper and this is the expected behaviour.
Comment #9
joelpittetComment #11
catchCommitted/pushed to 8.0.x, thanks!