Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
base system
Priority:
Major
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
5 Aug 2015 at 15:50 UTC
Updated:
19 Aug 2015 at 18:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
alexpottLess loops and less SafeMarkup::set() - I like it.
Comment #3
alexpottComment #4
xjmThis is great, and also makes #2505497: Support render arrays for drupal_set_message() potentially cleaner.
I think the only potential concern is with storing objects in
$_SESSIONas per @catch's concerns in #2505497: Support render arrays for drupal_set_message(). However, a SafeString object is definitely a much smaller/safer thing to put there than an entire render array. So I think that's acceptable.Comment #6
catchYep SafeString is a lot more limited than a render array, so no objections to this and it simplifies things as well.
Committed/pushed to 8.0.x, thanks!