We are unnecessarily escaping the value in template_preprocess_textarea() as Twig auto-escape will do this for us.

Calling SafeMarkup::checkPlain() unnecessarily pollutes the safe string list, therefore a bug.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug, because it is an unnecessary call to ::checkPlain
Issue priority Normal, because it is just one call.
CommentFileSizeAuthor
#2 2545988.2.patch722 bytesalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2545988.2.patch722 bytes
dawehner’s picture

dawehner
Primary language German
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

So this value is passed onto the template at which point we have escaping.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 78b1bdb on 8.0.x 
    Issue #2545988 by alexpott: Remove unnecessary SafeMarkup::checkPlain()...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.