file_create_filename() in file.inc does a check as to whether Drupal is running in Windows before eliminating characters that cannot be used in Windows file names. It would be better for site portability if these characters were always removed.

CommentFileSizeAuthor
#3 ensure-portability-2545614-3.patch894 bytescharles belov

Comments

Charles Belov created an issue. See original summary.

charles belov’s picture

charles belov
he/him
Primary language English
Location San Francisco, CA, US
commented
Version: 7.38 » 8.1.x-dev
Issue tags: +Needs backport to D7
charles belov’s picture

charles belov
he/him
Primary language English
Location San Francisco, CA, US
commented
Status: Active » Needs review
StatusFileSize
new ensure-portability-2545614-3.patch894 bytes

Adding patch for review

Status: Needs review » Needs work

The last submitted patch, 3: ensure-portability-2545614-3.patch, failed testing.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: +stale-issue-cleanup

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

charles belov’s picture

charles belov
he/him
Primary language English
Location San Francisco, CA, US
commented

There doesn't appear to be any corresponding code in the file module for Drupal 11. Closing as obsolete.

charles belov’s picture

charles belov
he/him
Primary language English
Location San Francisco, CA, US
commented
Status: Postponed (maintainer needs more info) » Closed (outdated)
quietone’s picture

quietone commented
Status: Closed (outdated) » Postponed (maintainer needs more info)

I found the code in core using git, git log -S'are not allowed in W'. It is at https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co.... So, restoring status.

charles belov’s picture

charles belov
he/him
Primary language English
Location San Francisco, CA, US
commented

@quietone Thank you! I had only looked in the module, not in the library.

@smustgrave I'm not sure what additional information you need. The code is still in 11.x and is therefore potentially an issue. Of course, the patch is out of date.

I just did a test on simplytest.me, which is apparently not a Windows machine.

  • File name on my Mac: file name with special chars /*?"<>|.txt
  • File name once uploaded to simplytest.me: file%20name%20with%20special%20chars%20%3A*%3F%2522%3C%3E%7C.txt
  • File name as shown in the Windows Edge address bar: file%20name%20with%20special%20chars%20%3A*%3F%2522<>%7C.txt
  • File name as downloaded to Windows 11: file name with special chars ___%22___.txt

So, it's not an issue that files originally stored on a non-Windows machine can't be accessed by a Windows machine.

My concern would be if the site were moved from a non-Windows host to a Windows host that the files would no longer be accessible. However, I have not tested this and, as QA not developer, don't have a way to test this hypothesis.

I do think it would be good if file names were consistent across platforms, as it would make diffing between two sites (one Windows, one non-Windows) or a non-Windows site and a Windows local machine development site easier.

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Active

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.