Problem/Motivation

\Drupal\views\ViewExecutable::setResponse should use \Symfony\Component\HttpFoundation\Response in the docs.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 use_absolute-2544122-3.diff609 bytesharjotsingh
#1 setResponse.png151.59 KBharjotsingh

Comments

harjotsingh’s picture

harjotsingh commented
StatusFileSize
new setResponse.png151.59 KB

I'm unsure what are the remaining task.
I could find only this in ViewExecutable.php

olli’s picture

olli commented
Issue tags: +VDC

@harjotsingh: if you compare the docs for ViewExecutable::setResponse and ::getResponse you'll see that ::setResponse @param line is missing one "\".

harjotsingh’s picture

harjotsingh commented
Status: Active » Needs review
StatusFileSize
new use_absolute-2544122-3.diff609 bytes

@olli
Thanks for telling , added the missing "\".

olli’s picture

olli commented
Status: Needs review » Reviewed & tested by the community

Great!

dawehner’s picture

dawehner
Primary language German
commented

Perfect!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Use absolute documentation for \Drupal\views\ViewExecutable::setResponse » Missing leading backslash in documentation for \Drupal\views\ViewExecutable::setResponse
Issue tags: +Documentation

Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Docs are nto frozen in beta. Committed 7fd9884 and pushed to 8.0.x. Thanks!

  • alexpott committed 7fd9884 on 8.0.x 
    Issue #2544122 by harjotsingh: Missing leading backslash in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.