Problem/Motivation

The tips.css within Bartik contains specific list styling for lists which is consistent with other list styles in Bartik. Tips.css also override consistent styles provided by the Content component in Bartik.

Proposed resolution

Remove the CSS file and the reference to it in bartik.libraries.yml.

Remaining tasks

Write a patch.
Provide screenshots.

User interface changes

None

API changes

None

Data model changes

None

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because we are cleaning up CSS and not causing any visual changes.
Issue priority Not critical because it is a CSS cleanup task
Unfrozen changes Unfrozen because it only removes unneeded CSS
Prioritized changes The main goal of this issue is to help provide easily maintainable code.
Disruption No disruption

Comments

emma.maria’s picture

Title: Remove "Tips" CSS from Bartik » Remove tips.css from Bartik
blacklabel_tom’s picture

Assigned: Unassigned » blacklabel_tom
blacklabel_tom’s picture

StatusFileSize
new896 bytes

Hi Emma,

Here is a patch for removing tips.css from the Bartik theme.

Let me know if it looks OK.

Cheers

Tom

blacklabel_tom’s picture

Status: Active » Needs review
gatorjoe’s picture

Patch #3 worked correctly for me

longwave’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new16.25 KB
new16.29 KB

There is a few pixels difference but it is not noticeable and it is more consistent with other list styles.

Before:

After:

emma.maria’s picture

Assigned: blacklabel_tom » Unassigned
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 9341eca and pushed to 8.0.x. Thanks!

  • alexpott committed 9341eca on
    Issue #2542202 by blacklabel_tom, longwave, emma.maria: Remove tips.css...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.