[regression] Toolbar subtrees have regressed: either fix or revert the regressions [#2541794]

Problem/Motivation

In HEAD, toolbar subtrees are not working (in vertical orientation, there are no drop-down arrows for expanding sections that should be expandable). This is a regression from beta-12, so we should fix that before tagging beta-13.

Proposed resolution

Option 1: commit #2535118: Toolbar subtrees not working on admin pages due to lack of theme negotiation on Toolbar's custom JSONP route.
Option 2: revert #2217985: Replace the custom menu caching strategy in Toolbar with Core's standard caching. and its follow-ups. If we choose this option, I think it would be ok to re-commit those patches after tagging beta-13.

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#1	toolbar-subtree-caching-revert.patch	16.75 KB	effulgentsia

Comments

Comment #1

effulgentsia commented 29 July 2015 at 00:48

Status	File	Size
new	toolbar-subtree-caching-revert.patch	16.75 KB

Here's a patch generated by running:

git revert 0feb1b6
git revert 7fb23ea
git revert cbcbfc1 
git diff origin/8.0.x

Thanks to @xjm for figuring out the required reversions and order.

Let's see if it passes tests.

Comment #2

wim leers

Ghent 🇧🇪🇪🇺

commented 29 July 2015 at 06:49

@effulgentsia on the other issue that would solve this critical:

Which means that the result isn't cached, and I end up seeing flicker (on Chrome) of the toolbar as I navigate the site.

FYI: With #2541794-1: [regression] Toolbar subtrees have regressed: either fix or revert the regressions, I do not see the extra http requests of #19, but I still see some toolbar flicker, e.g., when going between /admin/config/development/performance and /admin/config/development/logging. I thought there was a time when there wasn't that flicker, but I might be misremembering. Anyway, if there's a flicker either way, then #17.1 (commit what's here now and optimize later) seems acceptable to me.

Therefore he was +1 to commit #2535118: Toolbar subtrees not working on admin pages due to lack of theme negotiation on Toolbar's custom JSONP route, and not the patch here.

And since then, that issue has received a patch that fixes that extra HTTP request (that you only got when switching from one theme to another; as long as you stayed within a single theme, there was no extra HTTP request), thanks to a tiny change in client-side caching (cache the toolbar subtrees client-side per theme). Which addressed his final concern.