Problem/Motivation

Core issue #2513094: ContentEntityBase::getTranslatedField and ContentEntityBase::__clone break field reference to parent entity broke paragraph translation. The title gets translated, but the paragraph fields don't.

Proposed resolution

The problem may be in the code structure. Check the screenshot attached above.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
Screen Shot 2015-07-27 at 11.45.47.png17.49 KBsasanikolic
Screen Shot 2015-07-27 at 11.45.40.png25.55 KBsasanikolic

Comments

LKS90’s picture

LKS90 commented

The title gets translated, but the paragraph fields don't.

When editing, everything works as well. The correct translation just isn't displayed.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: Translated paragraphs not saved correctly » Translated paragraphs is not displayed in the correct translation

Confirmed. The data is saved correctly, the problem is somewhere in the entity reference revision formatter, the entity is simply rendered in the wrong language.

I believe that we've been relying on the bug fixed in #2513094: ContentEntityBase::getTranslatedField and ContentEntityBase::__clone break field reference to parent entity in getEntitiesToView() and the code there only works because of that.

The code is the same as the core entity formatters, so wondering if core is broken too and is missing test coverage for this.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Ouch. Yes, core is broken as well for similar scenarios: #2513094-44: ContentEntityBase::getTranslatedField and ContentEntityBase::__clone break field reference to parent entity

LKS90’s picture

LKS90 commented

With #2543258: Entity references of untranslatable fields are not displayed in the correct translation the translation works again. No change necessary for paragraphs, but entity_reference_revisions will need an update.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Active » Postponed

Still postponing this because we are blocked now.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Postponed » Fixed

The core issue is fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.