Problem/Motivation

After #2525910: Ensure token replacements have cacheability + attachments metadata and that it is bubbled in any case token module is basically broken as ->generate() breaks.

Let's fix that first and in an additional issue apply the needed metadata.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 2538552-7-interdiff.txt2.46 KBberdir
#7 2538552-7.patch17.16 KBberdir
#5 2538552-5.patch14.82 KBberdir
#1 2538552-1.patch14.8 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 2538552-1.patch14.8 KB

Here is a patch for that.

dawehner’s picture

dawehner
Primary language German
commented
Related issues: +#2538558: Token cacheablity metadata step 2: Apply the needed cacheability metadata

Let's add the other issue: #2538558: Token cacheablity metadata step 2: Apply the needed cacheability metadata

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Looks good.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Needs work

Patch needs a re-roll after #2516454: Append leading slash where necessary was committed.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 2538552-5.patch14.82 KB

Conflicted on one line, just added the new argument to the changed call from the other issue:

++<<<<<<< ours
 +      $replacements += \Drupal::token()->generate('array', $arg_tokens, array('array' => explode('/', ltrim($value, '/'))), $options);
++=======
+       $replacements += \Drupal::token()->generate('array', $arg_tokens, array('array' => explode('/', $value)), $options, $bubbleable_metadata);
++>>>>>>> theirs

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: 2538552-5.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new 2538552-7.patch17.16 KB
new 2538552-7-interdiff.txt2.46 KB

Missed a few places.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Committed #7 to 8.x-1.x.

  • Dave Reid committed 23e0e85 on 8.x-1.x authored by Berdir 
    Issue #2538552 by Berdir, dawehner: Fixed hook_tokens() missing new...

The last submitted patch, 1: 2538552-1.patch, failed testing.

Status: Fixed » Needs work

The last submitted patch, 7: 2538552-7.patch, failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Fixed

I fought the bot and the bot won.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.