For whatever reason, \Drupal\Core\Template\TwigNodeVisitor's functions don't have their scopes declared. Patch sets them to public which is how PHP has been treating them. By and large this is just a code standards compliance change.

CommentFileSizeAuthor
declare-scope-patch.diff1.49 KBAki Tendo

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

yeah there is no reason for them to not define them. They need to be public, as they are called from outside.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed ae85191 and pushed to 8.0.x. Thanks!

  • alexpott committed ae85191 on 8.0.x 
    Issue #2538294 by Aki Tendo: Formally declare public scope in \Drupal\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.