Problem/Motivation

Not sure if this problem only exists in 8.x but the module shouldn't redirect to e.g. an alias in case of a POST request since that will silently drop all POST data.

Proposed resolution

check the request method, skip if not GET/HEAD. Write a test for it.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 not_redirect_on_post-2537112-4.patch1.2 KBgiancarlosotelo
#2 not_redirect_on_post-2537112.patch1.2 KBgiancarlosotelo

Comments

giancarlosotelo’s picture

giancarlosotelo commented
Assigned: Unassigned » giancarlosotelo
giancarlosotelo’s picture

giancarlosotelo commented
Status: Active » Needs review
StatusFileSize
new not_redirect_on_post-2537112.patch1.2 KB

Here is the patch.

It needs #2529996: Paths require a forward slash prefix and #2532740: Fix incorrect config schema to work.

juanse254’s picture

juanse254 commented
Status: Needs review » Needs work 
+++ b/src/Tests/GlobalRedirectTest.php
@@ -153,6 +153,13 @@ class GlobalRedirectTest extends WebTestBase {
+    ¶

We can delete that line.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Needs review
StatusFileSize
new not_redirect_on_post-2537112-4.patch1.2 KB

The whole test has empty lines between comments, that's why I added the empty line but probably is better to have everything without that.