Webform labels don't render in 2.x

This needs to be added to the array returned by _webform_render_productfield:
'#title' => $filter ? _webform_filter_xss($component['name']) : $component['name'],

CommentFileSizeAuthor
#4 commerce_webform-2536028-4.patch1.5 KBjohnennew

Comments

karing’s picture

karing
Location 🇨🇦
commented
Issue summary: View changes
johnennew’s picture

johnennew commented

Hi Karin, Just catching up on these issues.

Are you sure this is needed as the title gets set by #title_display in _webform_render_productfield().

When I added #title, it ended up printing the title twice in some cases.

johnennew’s picture

johnennew commented

I think you are right actually, but I have a different issue when added.

When its a drop down select box then we see 2 title's with this change, but 1 title on radios and check boxes.

johnennew’s picture

johnennew commented
Status: Active » Reviewed & tested by the community
StatusFileSize
new commerce_webform-2536028-4.patch1.5 KB

I believe this patch works in all cases!

  • ceng committed f05b03d on 7.x-2.x authored by KarinG 
    Issue #2536028 by ceng, KarinG: '#title' not assigned in...
johnennew’s picture

johnennew commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x-2.x with thanks!

johnennew’s picture

johnennew commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.