Once #2506581: Remove SafeMarkup::set() from Renderer::doRender is in, we can remove the deprecated function SafeMarkup::checkAdminXss().

Beta phase evaluation

-->

Reference: https://www.drupal.org/core/beta-changes
Issue category Task. Work must be done to remove the deprecated checkAdminXss method before 8.0.0 release.
Issue priority Normal. Drupal 8 still works with this deprecated function still in place.
Prioritized changes The main goal of this issue is removing the already deprecated checkAdminXss method for 8.0.0.
Disruption Disruptive for core/contributed and custom modules/themes because it will require a BC break/deprecation/data model changes/an upgrade path/internal refactoring/widespread changes... (Which? Specify.)
CommentFileSizeAuthor
remove-safemarkup-checkadminxss.patch1.71 KBjeroent

Comments

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Postponed » Needs review

#2506581: Remove SafeMarkup::set() from Renderer::doRender is in.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Looks perfect

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Issue summary: View changes

RTBC +1. checkAdminXss() isn't used anywhere.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

The deprecation of this method was discussed at length in #2506581: Remove SafeMarkup::set() from Renderer::doRender. @David_Rothstein had some reservations about whether we should keep this. However, given the time passed since that was committed and the number of SafeMarkup issues being worked on I think it is okay to proceed with removal. Less SafeMarkup::methods() make it easier to use. Committed 2053325 and pushed to 8.0.x. Thanks!

  • alexpott committed 2053325 on 8.0.x 
    Issue #2536024 by JeroenT: Remove deprecated SafeMarkup::checkAdminXss()
David_Rothstein’s picture

David_Rothstein commented

For the record, I'm very on board with removing this (see my second comment on the issue); at one point I may have suggested keeping it temporarily while it was still being used in core, but overall wanted to remove it since it's confusing and also because I wanted to do #2531560: Add SafeMarkup::xssFilterAdmin() instead. But now I need to go figure out what the current status of that issue is since other things have changed since then...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.