Problem/Motivation

The doc block for NodeAccessControlHandlerInterface::writeGrants is outdated. The method has only two parameters.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#1 2534516.patch1.07 KBwebflo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
Issue summary: View changes
Status: Active » Needs review
FileSize
2534516.patch1.07 KB
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Tag1 Consulting commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

Perfect

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Related issues: +#2473021: Deprecate NodeAccessControlHandlerInterface::writeGrants() for removal in Drupal 9.0.x, +#2473093: Node access default grant behavior is not clear
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Fixed

Since this method basically just wraps NodeGrantDatabaseStorageInterface::write(), I double-checked that method too. That method still has these parameters. However, NodeGrantDatabaseStorageInterface::write() does this:

    $grants = $this->acquireGrants($node);
    $this->grantStorage->write($node, $grants, NULL, $delete);

So since it is providing defaults, looks like this patch is correct. I also double-checked that the base implementation has the correct signature.

See also #2473021: Deprecate NodeAccessControlHandlerInterface::writeGrants() for removal in Drupal 9.0.x.

This issue only changes documentation, so per https://www.drupal.org/core/beta-changes, this can be completed any time during the Drupal 8 beta phase. Committed and pushed to 8.0.x. Thanks @webflo for catching this!

  • xjm committed 291e4f5 on 8.0.x 
    Issue #2534516 by webflo: Fix NodeAccessControlHandlerInterface doxygen

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.