Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When a patch fails to apply, jenkins aborts the job, and no junit.xml is output. This causes drupalci to mark them as a 'Testbot Error' (white) vs as a red 'Failure' - a failed patch application should show up as a patch failure on d.o.
Comment | File | Size | Author |
---|---|---|---|
#9 | 2534144-failed-patches.patch | 2.35 KB | Mixologic |
Comments
Comment #1
MixologicComment #2
MixologicComment #3
MixologicComment #4
hestenetIdeally this should be represented on the dispatcher in junit xml output that can be parsed like any other result data.
This could be accomplished by the test runner itself validating whether the test completed and aborting if any particular step (such as applying the patch) fails.
Comment #5
hestenetPer jthorson, logic changes in #2558929: Testrunner code cleanup and refactoring should help to capture failed build steps as failures.
Comment #6
jthorson CreditAttribution: jthorson for Drupal Association commentedThose changes lay the groundwork, and provide a mechanism to stop execution upon failure ... the actual failure logic still needs to be built into the individual build step plugins. I can't remember if the key method is on $job or the class returned by $job->getJobResults().
Comment #7
MixologicThis has been brutally hacked in for the time being - i.e. its a straight xml string that gets spit out into the xml directory if a patch fails to apply. But its better than clicking through.
For some reason the commits arent showing up properly here, but heres a test run: https://dispatcher.drupalci.org/job/DCI_XML/132/testReport/
Comment #8
MixologicOkay, here's an example of how it will look on drupal.org for the time being.
https://staging.devdrupal.org/pift-ci-job/33336
I think we can commit this now, and then drumm can later use the Testsuite Error message to bubble up the Patch Fail message.
Comment #9
Mixologicand heres a patch for review.
Comment #10
basic CreditAttribution: basic at Drupal Association commentedLooks good.
Comment #11
MixologicAight this hot mess hack is now in. Good.