Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I can't believe someone committed this to a project used on > 420,000 sites.
http://cgit.drupalcode.org/jquery_update/tree/replace/ui/external/jshint...
The Software shall be used for Good, not Evil.
https://github.com/jshint/jshint#license
JSHint is distributed under the MIT License. One file and one file only (src/stable/jshint.js) is distributed under the slightly modified MIT License.
It looks like there has been an attempt to fix this in https://github.com/jshint/jshint/issues/1234, but that the original author doesn't want the licensing changed.
Unless you can get a copy of jshint.js with a clean MIT license, it must be removed from the project. If that file is required, users will have to re-add it themselves... assuming they don't intend to do any evil with their Drupal site.
Comments
Comment #1
kreynen CreditAttribution: kreynen at University of Colorado Boulder commentedComment #2
markhalliwellWTF...
This file was added in #1947438: Update jQuery UI to the latest version (1.10.2) (d32f50d) for some reason. JSHint has nothing to do with the jQuery UI replacement files though, I don't know why it's even in there. The only thing I can imagine is that the entire folder was replaced with the source code of jQuery UI, which may have included this file?
Regardless, I agree it should come out. It doesn't belong in this project to begin with.
Comment #3
markhalliwellActually most of those files in the external folder are not compatible and the only file that jquery_update actually uses is
jquery.cookie.js(which is dual licensed as MIT/GPL2).I'll commit fixes for both 7.x-2.x and 7.x-3.x. Not sure when a release will happen though.
Comment #6
markhalliwell