Problem/Motivation

#2304949: Port HTTP Host header DoS fix from SA-CORE-2014-003 included a @todo for https://github.com/symfony/symfony/issues/12349, which led to https://github.com/symfony/symfony/pull/13522 and https://github.com/symfony/symfony/pull/13582. All three of those have been closed, so we should resolve this @todo.

Proposed resolution

Delete the comment. Nothing was committed.

Remaining tasks

Write patch.

User interface changes

None.

API changes

None.

Data model changes

None.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it fixed documentation
Issue priority Not critical because it is a simple documentation fix to address a Symfony issue that was closed.
Unfrozen changes Unfrozen because it only changes documentation/tests.
CommentFileSizeAuthor
#1 resolve_todo_for-2533218-1.patch606 bytesmpdonadio

Comments

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
commented
Issue summary: View changes
StatusFileSize
new resolve_todo_for-2533218-1.patch606 bytes

Unless I am missing something, I am not seeing any commits from the three issues linked in the IS.

Contender for trivial patch of the week?

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
commented
Status: Active » Needs review

/grrr

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Here we go thanks for creating the issue.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice catch!

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 5abb714 on 8.0.x 
    Issue #2533218 by mpdonadio: Resolve todo for Symfony #12349

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.