CommentFileSizeAuthor
#3 2532944_3.patch958 byteschx
#1 2532944_1.patch467 byteschx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chx’s picture

chx CreditAttribution: chx commented
Status: Active » Needs review
FileSize
2532944_1.patch467 bytes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Tag1 Consulting commented

Do you mind fixing \Drupal\Core\Path\AliasManager at the same time?

chx’s picture

chx CreditAttribution: chx commented
FileSize
2532944_3.patch958 bytes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Tag1 Consulting commented
Status: Needs review » Reviewed & tested by the community

Better than nothing, this is for sure! Thank you

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2532944_3.patch, failed testing.

Status: Needs work » Needs review

chx queued 3: 2532944_3.patch for re-testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Reviewed & tested by the community

Bot fluke

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Fixed

Looks good, thanks!

This issue only changes documentation, so per https://www.drupal.org/core/beta-changes, this can be completed any time during the Drupal 8 beta phase. Committed and pushed to 8.0.x.

  • xjm committed 76b6358 on 
    Issue #2532944 by chx, dawehner: AliasManagerInterface lacks doxygen

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.