See parent issue for details

CommentFileSizeAuthor
#5 interdiff-2531688-2-5.txt1012 byteskekkis
#5 2531688-5.patch6.87 KBkekkis
#2 core-jsdoc-toolbar-2531688-2.patch6.38 KBnod_
#2 interdiff.txt633 bytesnod_
#1 jsdoc_toolbar_module-2531688-1.patch5.93 KBeiriksm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
CreditAttribution: eiriksm at Ny Media AS commented
Status: Active » Needs review
FileSize
jsdoc_toolbar_module-2531688-1.patch5.93 KB
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ as a volunteer commented
FileSize
interdiff.txt633 bytes
core-jsdoc-toolbar-2531688-2.patch6.38 KB

Missing a couple of parameters descriptions

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ as a volunteer commented
Status: Needs review » Needs work

Missing @prop in behavior docblock

kekkis’s picture

kekkis
he/him
Primary language Finnish
Location Pirkkala
CreditAttribution: kekkis as a volunteer commented
Assigned: Unassigned » kekkis

Going to work on this in today's Drupalcamp Baltics sprint.

kekkis’s picture

kekkis
he/him
Primary language Finnish
Location Pirkkala
CreditAttribution: kekkis as a volunteer commented
FileSize
2531688-5.patch6.87 KB
interdiff-2531688-2-5.txt1012 bytes

Added @prop's for the behaviors in the toolbar directory.

kekkis’s picture

kekkis
he/him
Primary language Finnish
Location Pirkkala
CreditAttribution: kekkis as a volunteer commented
Status: Needs work » Needs review
kekkis’s picture

kekkis
he/him
Primary language Finnish
Location Pirkkala
CreditAttribution: kekkis as a volunteer commented
Assigned: kekkis » Unassigned

Sorry for the forgetfulness. My first issue. Maybe I'll remember to set all the fields in one go next time.

evilfurryone’s picture

evilfurryone CreditAttribution: evilfurryone at Wunder commented
Status: Needs review » Reviewed & tested by the community

Comments in the code verified.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ as a volunteer commented

RTBC +1

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed a937892 on 8.0.x 
    Issue #2531688 by kekkis, nod_, eiriksm, evilfurryone: JSDoc toolbar...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.