Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Jul 2015 at 17:24 UTC
Updated:
28 Oct 2015 at 20:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
orbmantell commentedComment #2
traviscarden commentedThese two sentences are so closely related they should follow one another immediately (No paragraph break.)
In the added sentence, "the module" is ambiguous. (What module?) And as I'm unable to find any other reference in the codebase to a schema as "raw", I would propose alternative language. Perhaps something like, "To get the schema without modifications, use drupal_get_schema_unprocessed()."
Since you're already mentioning the function above with explanation, it's probably not necessary to also add an
@seereference.This could use an explanation parallel to the one proposed for
drupal_get_schema_unprocessed()above indrupal_get_schema(). I would remove the@seereference and add a sentence at the end of the second paragraph: "...and these unprocessed definitions won't be cached."Comment #3
orbmantell commentedNew patch attached to address the issues in #2
Comment #4
traviscarden commentedLooks good!
Comment #5
jhodgdon+1, thanks! Quick note: these functions do not exist, apparently, in Drupal8.
Comment #6
David_Rothstein commentedCommitted to 7.x - thanks!
In Drupal 8 this has been renamed to drupal_get_module_schema() and slightly changed (see https://www.drupal.org/node/2467521) but since there's only one function there rather than two, this change would not be relevant for Drupal 8.