Problem/Motivation

There were some notices showing up in the admin page and the weights were blank. I looked into it further and noticed a translated string was used as the option key.

Proposed resolution

commerce_physical has a option method. use that:)

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#1 physical_weight_units_s-2530844-1.patch922 bytesjoelpittet

Comments

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new physical_weight_units_s-2530844-1.patch922 bytes

Try this on for size, I think it'll look good on you;)

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

FYI, abbreviation and the keys from the option list are the same thing just untranslated. So don't worry won't break existing sites... unless they translated the abbreviation... then well, turkeys!

  • iswilson committed 3d9c927 on 7.x-2.x authored by joelpittet 
    Issue #2530844 by joelpittet: physical_weight_units's abbreviation...

  • iswilson committed 670e3d3 on 7.x-1.x authored by joelpittet 
    Issue #2530844 by joelpittet: physical_weight_units's abbreviation...
iswilson’s picture

iswilson commented
Assigned: Unassigned » iswilson
Status: Needs review » Fixed

Tweaked a tiny bit and committed to both branches, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.