Problem/Motivation

Noticed while debugging a profile problem that there were two commerce_objects on $form_state. One keyed by commerce as 'order' and one added by commerce_fieldgroup_panes_contents_checkout_form() keyed by 'commerce_order'.

Proposed resolution

Remove the form_state bloat.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#1 2528424-1.patch808 bytesjoelpittet

Comments

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
StatusFileSize
new 2528424-1.patch808 bytes

I don't see where this is being used, so I just removed it and the unused variable.

Hopefully if there is any need for it it can be transferred to the 'order' key on form_state... but let's go with the simplest solution first.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

This seems to have 0 effect on whether the fieldgroup'ed forms save. But has a nice gain of not having to pass around that extra and sometimes large form_state object.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Needs review » Fixed

I think that's been there since forever, good catch, removing it, thanks for the patch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.