Currently we only add classes for error or warning, this doesn't afford us the flexibility to properly denote ok or info messages.

CommentFileSizeAuthor
#2 Status_report___Site-Install.png31.28 KBtimmillwood
#1 2528242-1.patch816 bytestimmillwood

Comments

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs work » Needs review
StatusFileSize
new 2528242-1.patch816 bytes

Patch for this.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Issue summary: View changes
StatusFileSize
new Status_report___Site-Install.png31.28 KB

To give an example of the result of this patch.
Example image

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Issue summary: View changes
oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Reviewed & tested by the community

Yeah! Coherence and less code.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented

This relates to #2528270: Use RequirementSeverity::OK by default

lewisnyman’s picture

lewisnyman
he/him
commented
Issue tags: +frontend, +CSS

I'm happy with this change, as it doesn't affect the design in the Seven theme and there might be some admin themes that would want to use this class. For example, bootstrap has an info color class.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Templates aren't frozen and this makes sense. Committed b2e29eb and pushed to 8.0.x. Thanks!

  • alexpott committed b2e29eb on 8.0.x 
    Issue #2528242 by timmillwood: Add color-*  classes to all rows on the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.