Try to get rid of Url::fromRoute() in system_js_settings_alter()

Assigning to @nod_ to get his feedback; he has tried to remove it in the past.

I think one of the "get rid of url()" issues has some thoughts on this, too. I seem to recall spending some time on it w/o luck. I'll poke around.

scriptPath was removed

Oh, hah! Yay :) One less thing to worry about :)

+++ b/core/modules/system/system.module
@@ -649,21 +649,19 @@ function system_js_settings_build(&$settings, AttachedAssetsInterface $assets) {
+  // Let output path processors set a prefix.
+  /** @var \Drupal\Core\PathProcessor\OutboundPathProcessorInterface $path_processor */
+  $path_processor = \Drupal::service('path_processor');
+  $path_processor->processOutbound('', $options);
+  $pathPrefix = $options['prefix'];

I like this idea a lot. Let's see if testbot likes it as much!

I'm really not up to speed on how to get all that from the PHP so as long as it's gone and testbot is happy, I'm good with it.

RTBC, very happy about the change.

Profiled at /contact. Wall time delta is not to be trusted (too much variance); the other deltas are steady. Saves 54 function calls.

What about just comparing this function.. There shouldn't be a lot of variance then.

I don't see the value of micro-profiling a function that's only called once per page load?

More about interest than necessity I think - I posted a 'before' when I opened #2505055: Remove isFront from system_js_settings_alter().

I don't see the value of micro-profiling a function that's only called once
per page load?

Why would you not want to compare the actual function that is changing? There's no point in comparing the whole request if we know that nothing outside that function is changed.

And yes, I asked because I saw that issue that @catch created.

Apologies, I didn't realize that it was taking 1.5 ms. Then micro profiling definitely makes sense.

+++ b/core/modules/system/system.module
@@ -648,21 +648,20 @@ function system_js_settings_build(&$settings, AttachedAssetsInterface $assets) {
-  $scriptPath = $request->getScriptName();
...
-    'scriptPath' => $scriptPath,

Why have we removed this? Ah because we don't need it since #2362227: Replace all instances of current_path() and it's an Drupal 8 only thing. I guess this is okay to remove without a CR.

Didn't mean to change the status.

Committed/pushed to 8.0.x, thanks!