Problem/Motivation

#2509898: Additional uncaught exception thrown while handling exception after service changes introduced some tests that relied on running the test with a container builder.

However #2497243: Replace Symfony container with a Drupal one, stored in cache ensures that only the container is used and never the ContainerBuilder.

Proposed resolution

- Fix it

Remaining tasks

- Fix it

User interface changes

API changes

Data model changes

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because it relies on internals for testing, the unwanted behavior that a ContainerBuilder is used after a rebuildContainer().
Issue priority Major because it blocks a critical.
Unfrozen changes Unfrozen because it only changes tests.
Disruption Not disruptive.
CommentFileSizeAuthor
#1 regression_decouple-2527710-1.patch2.02 KBFabianx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Fabianx’s picture

Title: Regression: Decouple Error testing from running with container builder » Decouple Error testing from running with container builder
Issue summary: View changes
Issue tags: +Quickfix
FileSize
2.02 KB

- Added beta evaluation.
- Fixed it.

The fix is to use an alter() ServiceProvider pass to store the $container_builder that is used.

This ensures the original intent of the test is preserved.

Fabianx’s picture

Status: Needs work » Needs review
znerol’s picture

Status: Needs review » Reviewed & tested by the community

That works for me. Thanks!

We should also ping @bzrudi71 about that in order to see whether this also fixes the CI issues.

amateescu’s picture

@znerol, I just tried locally and the patch does not solve the DrupalCI failure :(

dawehner’s picture

Ha tricky!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed f3a857f and pushed to 8.0.x. Thanks!

  • alexpott committed f3a857f on 8.0.x
    Issue #2527710 by Fabianx: Decouple Error testing from running with...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.