Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
#2509898: Additional uncaught exception thrown while handling exception after service changes introduced some tests that relied on running the test with a container builder.
However #2497243: Replace Symfony container with a Drupal one, stored in cache ensures that only the container is used and never the ContainerBuilder.
Proposed resolution
- Fix it
Remaining tasks
- Fix it
User interface changes
API changes
Data model changes
Beta phase evaluation
Issue category | Bug because it relies on internals for testing, the unwanted behavior that a ContainerBuilder is used after a rebuildContainer(). |
---|---|
Issue priority | Major because it blocks a critical. |
Unfrozen changes | Unfrozen because it only changes tests. |
Disruption | Not disruptive. |
Comment | File | Size | Author |
---|---|---|---|
#1 | regression_decouple-2527710-1.patch | 2.02 KB | Fabianx |
Comments
Comment #1
Fabianx CreditAttribution: Fabianx as a volunteer commented- Added beta evaluation.
- Fixed it.
The fix is to use an alter() ServiceProvider pass to store the $container_builder that is used.
This ensures the original intent of the test is preserved.
Comment #2
Fabianx CreditAttribution: Fabianx as a volunteer commentedComment #3
znerol CreditAttribution: znerol commentedThat works for me. Thanks!
We should also ping @bzrudi71 about that in order to see whether this also fixes the CI issues.
Comment #4
amateescu CreditAttribution: amateescu for Pfizer, Inc. commented@znerol, I just tried locally and the patch does not solve the DrupalCI failure :(
Comment #5
dawehnerHa tricky!
Comment #6
alexpottCommitted f3a857f and pushed to 8.0.x. Thanks!