When support for templates was committed to Migrate (in #2463909: Migrations should support non-installed default configurations (templates)), MigrateDrupal6TestBase got a setUp() method which calls installMigrations('Drupal 6'), which creates migration entities from all templates tagged for Drupal 6.
Unfortunately, we forgot to add a similar method to MigrateDrupal7TestCase, which means that Drupal 7 migration tests cannot pass testbot. Since there are many D7 migrations with tests that need to be reviewed and committed, this is a pretty big blocker.
The attached patch adds the required call to MigrateDrupal7TestBase.
| Comment | File | Size | Author |
|---|---|---|---|
| migrate-d7_test_fix.patch | 616 bytes | phenaproxima |
Comments
Comment #1
phenaproximaComment #2
neclimdulI'm optimistic and this is straight forward.
Comment #3
webchickOopsie. ;)
Committed and pushed to 8.0.x. Thanks!
Comment #6
xjmSo somehow, this issue added two setUp() methods to the class, causing HEAD to fail with a syntax error because the method was redeclared. I also couldn't revert it properly for some reason, so I fixed it manually.
Comment #7
xjmFollowup: It looks like @webchick accidentally committed this patch a second time with a commit message for #2525870: Regression: machine name inputs no longer work properly after #2508735 which is why I got a merge conflict when I tried to revert. Oops. I'll follow up on that issue as well.
Comment #8
phenaproximaWhoops. I saw weird test failures related to that, but I figured it was just testbot being passive-aggressive. Thanks, @xjm!