Apologies for being a bit slow in getting this back upstream. Our team has been working on a Drupal 8 port of Views GeoJSON, and while there are some rough edges, it's ready for review (and IMO an 8.x-1.x branch could be based on this patch).

I don't know if there's a good way to preserve commit history so the [people who worked on the D8 port](https://github.com/savaslabs/views_geojson/graphs/contributors) could get credit, but if so that would be great.

CommentFileSizeAuthor
#22 Bildschirmfoto_2019-11-26_12-27-54.png142.64 KBmmbk
#1 port_to_drupal_8-2527636-1.patch50.52 KBkostajh

Comments

kostajh’s picture

kostajh commented
StatusFileSize
new port_to_drupal_8-2527636-1.patch50.52 KB
kostajh’s picture

kostajh commented
Status: Active » Needs review
pol’s picture

pol
Location Brussels
commented
Assigned: Unassigned » pol

Super !!

Will review this tonight or tomorrow.

Thanks!

kostajh’s picture

kostajh commented

Thanks @Pol. Here's a post that outlines the step-by-step instructions for working with the D8 version, in case that's helpful to you.

kostajh’s picture

kostajh commented

Hi @Pol, hope you're doing well, I just got back from holiday and would like to move this forward again. Please let me know after you've had a chance to review again. Thanks!

pol’s picture

pol
Location Brussels
commented

Hello there,

Have you updated the github tree ? Is it working with the branch 8.0.x ?

Thanks

kostajh’s picture

kostajh commented
Status: Needs review » Needs work

@Pol let me check that it works with 8.0.0-beta14. I'd rather do that than try to catch 8.0.x :-)

kostajh’s picture

kostajh commented

Sadly, looks like Geofield is broken in D8 beta14, so I need to put some work into getting that working before I can move forward with finishing up Views GeoJSON for D8.

mpgeek’s picture

mpgeek commented

Adding a related issue. A port of Leaflet GeoJSON (for in-ui map placement with Beans and Panels) is on the horizon at #2578525: Port to Drupal 8.

pol’s picture

pol
Location Brussels
commented

@kostajh Any update on this port ?

mpgeek’s picture

mpgeek commented
kostajh’s picture

kostajh commented

@Pol haven't had a chance to work on this more but I believe the blocking issues are in Geofield, see in particular #1957760: Geofield D8 port and #2535450: The "GeoType" plugin does not exist. Once Drupal 8 RC1 is out I'll pick up the thread on this work again.

markusa’s picture

markusa commented

Can you'll provide a status update? Is Views GeoJSON and geofield for D8 working?

kostajh’s picture

kostajh commented

@markusa we're using the module on a production site. Have a look at https://github.com/savaslabs/durham-civil-rights-map . Our latest code is here https://github.com/savaslabs/views_geojson

kostajh’s picture

kostajh commented

@Pol could we open up an 8.x-1.x branch based on the GitHub repo above? We (Savas Labs) can help with patch review and such.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs work » Reviewed & tested by the community

Hello

I'm using this module in a D( siteand works fine for me.

I'm using the code from https://github.com/savaslabs/views_geojson

Should be easy to preserve the commit history given that this Github repository is built on top of the current drupal module, so current maintainer could just merge the Github repository in the d.o one, or give access to kostajh to merge the repositories and push the new version.

Thanks!

pol’s picture

pol
Location Brussels
commented

Hi,

It's now synced.

kostajh’s picture

kostajh commented

Thanks! I'll update the GitHub repo to point people back here.

jennypanighetti’s picture

jennypanighetti commented

Does the module 8.x-1.x-dev contain the code from github? I'll be using this in a production site soon and want to make sure I have the most up-to-date code and patches. Thanks.

kostajh’s picture

kostajh commented

@jenstechs yes, compare https://www.drupal.org/node/1187448/commits with https://github.com/savaslabs/views_geojson/commits/8.x-1.x

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented

Thanks Pol!

This is awesome :)

Do you think it's working well or do you consider any improvement to current code to tag first alpha/beta version?

Thanks again :)

mmbk’s picture

mmbk
Primary language German
Location Meißen
commented
StatusFileSize
new Bildschirmfoto_2019-11-26_12-27-54.png142.64 KB

We are working with this module for at least one year in a production-environment, so far it's running pretty well.

One thing is very strange: when installing the module via composer, it is checked out correctly, but the update status does not recognize the installed Version correctly.

I guess this will be fixed as soon as a first release is tagged. So I second #21 to create a first release,

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Version: 7.x-1.x-dev » 8.x-1.x-dev

+1 to doing a stable release of D8 version.

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
commented
Status: Reviewed & tested by the community » Fixed

8.x-1.0-rc1 tagged and released.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.