See parent issue for details.

CommentFileSizeAuthor
#1 jsdoc_history_module-2526406-1.patch2.11 KBeiriksm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
CreditAttribution: eiriksm at Ny Media AS commented
Status: Active » Needs review
FileSize
jsdoc_history_module-2526406-1.patch2.11 KB

No eslint issues on this one, only fixed comment lines with more than 80 chars.

There was 1 one-line summary I changed the wording on (Marks a node as read, store the last read timestamp in client-side storage. => Marks a node as read, store the last read timestamp client-side.) to make it fit on one line

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Looks good.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 84407eb on 8.0.x 
    Issue #2526406 by eiriksm: JSDoc history module

Status: Fixed » Needs work

The last submitted patch, 1: jsdoc_history_module-2526406-1.patch, failed testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.