Uncomment StatementInterface methods

Sounds like this is actually a bug then, found by enforcing the interface.

+++ b/core/lib/Drupal/Core/Database/Statement.php
@@ -127,4 +127,30 @@ public function rowCount() {
+  public function setFetchMode($mode, $a1 = NULL, $a2 = array()) {
+    // Call \PDOStatement::setFetchMode to set fetch mode.
+    return parent::setFetchMode($mode);
+  }

Wait, why are we dropping the other two parameters? Don't they serve some purpose in the world?

Huzzah! Thanks, neclimdul.

1. Given that we are now enforcing expectations through an interface I think we should have a small CR telling people this.

2. +++ b/core/lib/Drupal/Core/Database/StatementPrefetch.php
   @@ -438,14 +438,14 @@ public function fetchAssoc() {
    
   -  public function fetchAll($fetch_style = NULL, $fetch_column = NULL, $constructor_args = NULL) {
   -    $this->fetchStyle = isset($fetch_style) ? $fetch_style : $this->defaultFetchStyle;
   +  public function fetchAll($mode = NULL, $column_index = NULL, $constructor_arguments = NULL) {
   

   Missing {@inheritdoc} - in fact I think we should fix all the implementations to use the {inheritdoc} now that the interface has the methods.

3.   /**
      * @see \PDOStatement::setFetchMode()
      */
     public function setFetchMode($fetchStyle, $a2 = NULL, $a3 = NULL) {
   

   In core/lib/Drupal/Core/Database/StatementPrefetch.php can inheritdoc plus the args don't match.

Change notice: https://www.drupal.org/node/2539326

Thanks, neclimdul!

+++ b/core/lib/Drupal/Core/Database/StatementPrefetch.php
@@ -268,14 +261,7 @@ public function setFetchMode($fetchStyle, $a2 = NULL, $a3 = NULL) {
-   * This is the core method of this class. It grabs the value at the current
-   * array position in $this->data and format it according to $this->fetchStyle
-   * and $this->fetchMode.

We shouldn't lose this comment, we can either put it back below @inheritdoc or in the function body. Since dreditor context is not helpful, the comment was in the docblock of the current() method.

Bot should be OK.

Cool :)

Committed 42c26e2 and pushed to 8.0.x. Thanks!

I think ... the change record might be slightly misleading? Statements still implements StatementInterface, we just added a few new methods do it so that it mirrors PDOStatement 100% but we do not actually require to implement / extend / whatever PDO itself.

I rewrote the CR from ground up from the viewpoint of someone who actually wrote DB drivers :) and changed the title too because the title was very confusing (since PDOStatement doesn't have an interface)