The openid_sha1 function is called with more arguments than it can accept. This patch cleans that up.

CommentFileSizeAuthor
#3 openid-sha1-D6-1.patch1.31 KBc960657
openid.patch391 bytesjax

Comments

Leeteq’s picture

Leeteq commented

Subscribing...

heine’s picture

heine commented
Status: Needs review » Needs work

Seems like this sha1 wrapper was written to emulate the $raw_output parameter of sha1 on pre PHP 4. The function can be removed in HEAD.

There are more calls with a second argument TRUE.

c960657’s picture

c960657 commented
Version: 6.2 » 6.x-dev
Priority: Normal » Minor
Status: Needs work » Needs review
StatusFileSize
new openid-sha1-D6-1.patch1.31 KB

This handles all occurrences of _openid_sha1(..., TRUE).

Note that the patch is for D6. _openid_sha1() has been removed in D7.

Status: Needs review » Needs work

The last submitted patch, openid-sha1-D6-1.patch, failed testing.

c960657’s picture

c960657 commented
Status: Needs work » Needs review

#3: openid-sha1-D6-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, openid-sha1-D6-1.patch, failed testing.

c960657’s picture

c960657 commented
Status: Needs work » Needs review

There must be some problems with the test bot. The patch applies cleanly here.

Anonymous’s picture

Anonymous (not verified) commented

#3: openid-sha1-D6-1.patch queued for re-testing.

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.