Enforced configuration dependencies shouldn't have to be repeated in the calculated dependencies

As discussed, it would be great if we could check the return value in the one call to calculateDependencies() that really counts and throw a helpful exception about what changed and what you need to update. Then fixing it will be easy, not too worried about that.

I counted around 5 modules/project that this breaks that I'm using.

As discussed, it would be great if we could check the return value in the one call to calculateDependencies() that really counts and throw a helpful exception about what changed and what you need to update.

AFAICT once this is done, this is RTBC.

+++ b/core/modules/system/src/Tests/Update/UpdatePathTestBaseFilledTest.php
@@ -415,6 +416,12 @@ public function testUpdatedSite() {
+    // Ensure that the Book module's node type does not have duplicated enforced
+    // dependencies.
+    // @see system_post_update_fix_enforced_dependencies()
+    $book_node_type = NodeType::load('book');
+    $this->assertEqual(['enforced' => ['module' => ['book']]], $book_node_type->get('dependencies'));

Book module being tested in a System module test… smells fishy. But apparently this is pre-existing.

(This really belongs in Standard AFAICT.)

Wow that test sucks.

+1, been bit by that too :P

Committed/pushed to 8.0.x, thanks!

That test is super painful indeed :-/
(and #2578249: Some e_r fields get the wrong Selection handler, that has to do the same, will need a reroll :-p)