Mostly I feel this module is used for fetching images. This is very useful if I need those files locally to do some processing on (like new image styles), so hotlinking is not an option in this case.

Sometimes there are files that don't need to be fetched locally but are on the production site, OR the files are so large that it maxes out PHP's memory limit.
In my case, we have 100MB mp3 files that I'd rather not have PHP download and store locally.

Instead, I propose to add an option to exclude those file types. Here is a patch which accomplishes this.

CommentFileSizeAuthor
#14 stage_file_proxy-file_extension_includes-2514772-14.patch2.56 KBmandclu
#10 2514772-D8-2.patch3.36 KBjeroent
#8 2514772-D8.patch3.36 KBjeroent
#3 add_file_extension-2514772-3.patch1.24 KBmarkdorison
stage_file_proxy-add_extension_exclusion.patch1.39 KBstevenlafl

Issue fork stage_file_proxy-2514772

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ciss’s picture

ciss commented
Related issues: +#2495299: Implement a skip paths regex
asrob’s picture

asrob
he/him
Primary language Hungarian
Location Hungary 🇭🇺 🇪🇺
commented
Version: 7.x-1.7 » 7.x-1.x-dev
Status: Needs review » Reviewed & tested by the community

I've successfully applied this patch. I think it works well, I can easily adjust it via UI.

markdorison’s picture

markdorison
he/him
commented
StatusFileSize
new add_file_extension-2514772-3.patch1.24 KB

Fixed typo in module name and modified end of description text. No functional changes.

BarisW’s picture

BarisW commented

Works great. Thanks for the patch and thanks all for testing.

  • BarisW committed 2930cc6 on 7.x-1.x authored by stevenlafl 
    Issue #2514772 by stevenlafl, markdorison, ciss, asrob, BarisW: Add file...
BarisW’s picture

BarisW commented
Status: Reviewed & tested by the community » Fixed

Committed to dev.

BarisW’s picture

BarisW commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Assigned: stevenlafl » Unassigned
Status: Fixed » Patch (to be ported)

Needs a D8 port

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 2514772-D8.patch3.36 KB

Attached the D8 version of this patch.

Status: Needs review » Needs work

The last submitted patch, 8: 2514772-D8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new 2514772-D8-2.patch3.36 KB

Fixed coding standards.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 10: 2514772-D8-2.patch, failed testing. View results

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review
mandclu’s picture

mandclu commented
StatusFileSize
new stage_file_proxy-file_extension_includes-2514772-14.patch2.56 KB

Here's an updated patch that should apply on the current dev branch. Using composer the only part that wouldn't apply is the change in dependency declarations, and those changes didn't seem necessary anyway.

rikki_iki’s picture

rikki_iki commented
Status: Needs review » Reviewed & tested by the community

Patch from #14 works. Great feature

smustgrave made their first commit to this issue’s fork.

smustgrave opened merge request !17

  • smustgrave committed efa788a on 8.x-1.x 
    Issue #2514772: Add file extension exclusion list
smustgrave’s picture

smustgrave commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.