Text can't be selected via click and drag when the Drupal drag and drop interface is present in IE7 [#251402]

What I'm seeing (in IE7) is that whenever the Drupal drag and drip interface is present on a form (ie. menus, block, even node edit with something like imagefield that uses it) you can no longer "select" text on the page, or in any of the other form fields present, via click and drag selection.

While this isn't really a problem for something like the menu or block admin pages, when editing a node that has a field which uses the drag and drop interface, you can no longer select text in text area fields by drag and select which can be troublesome. Selection of text through double and triple clicks still works as expected. I'm seeing this in IE7, all works fine in FF of course :)

Comment	File	Size	Author
#1	tabledrag_ie7_mousemove.patch	1.07 KB	quicksketch
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

quicksketch

he/him

CreditAttribution: quicksketch commented 3 June 2008 at 22:06

Version:	6.2	» 7.x-dev
Status:	Active	» Needs review

File	Size
tabledrag_ie7_mousemove.patch	1.07 KB

Moonshine, you nailed this one on the head. Tabledrag is definitely causing the problem. In a weird quirk between browsers, IE7 allows you to return FALSE on mousemove, which disables the selection of text. Other browsers disable the dragging of images or links, but IE7 seems to be alone in disabling the selection of text.

Our mousemove event is currently bound to the entire page, and always returns false. This isn't correct handling, as we should only be returning false if a drag and drop row is taking effect. This patch moves the returning of false to inside the IF statement, making sure that tabledrag.js only affects mousemove if it's affecting a tablerow.

Works great on IE6/7, Firefox 2, and Safari 3.1. This patch is for 7.x HEAD, but should apply to the 6.2 version also.

Comment #2

Moonshine CreditAttribution: Moonshine commented 4 June 2008 at 15:33

Working great in 6.2. Thank you Quicksketch! :)

Comment #3

desbeers CreditAttribution: desbeers commented 5 June 2008 at 13:00

I had exactly the same problem with selecting text in Safari 3.1.1.
Also tested the patch in Firefox 2 and 3 on a Mac and all 3 browsers are fine (FF was never a problem). I have no IE at hand to test so leave the status CNR.

Thanks a lot Quicksketch, it drove me nuts!