Problem/Motivation

Blocks #2429617: Make D8 2x as fast: Dynamic Page Cache: context-dependent page caching (for *all* users!), causes 2 test failures there.

Proposed resolution

Invalidate the render cache when the State entry is modified.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#1 2512580-1.patch851 byteswim leers

Comments

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 2512580-1.patch851 bytes
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Seems fine, since this is a test-only scenario. Isn't there a more specific cache that that we could use, though?

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Perhaps we could, but there's little value in doing so.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 99cd5a6 and pushed to 8.0.x. Thanks!

  • alexpott committed 99cd5a6 on 8.0.x 
    Issue #2512580 by Wim Leers: NodeEntityViewModeAlterTest uses State to...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Thanks! SmartCache issue updated :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.