EntityDeriver.php contains the following unused namespaces:
Drupal\Core\Routing\RouteBuilderInterface
Drupal\Core\Routing\RouteProviderInterface
Symfony\Component\Routing\Exception\RouteNotFoundException

CommentFileSizeAuthor
#5 2512444-5.patch702 bytesMattA
#3 2512444-3.patch717 bytesMattA
#2 2512444-2.patch1.4 KBMattA
#1 2512444.patch1.78 KBMattA

Comments

MattA’s picture

MattA commented
Status: Active » Needs review
StatusFileSize
new 2512444.patch1.78 KB
MattA’s picture

MattA commented
Title: Unused namespaces in EntityDeriver.php (and a comment typo). » Unused namespaces in EntityDeriver.php
Issue summary: View changes
StatusFileSize
new 2512444-2.patch1.4 KB

Rerolled since comments were fixed in #1392754: Comply with new documentation standards for @file for namespaced class files.

MattA’s picture

MattA commented
StatusFileSize
new 2512444-3.patch717 bytes

Messed up encoding in patch file.

Status: Needs review » Needs work

The last submitted patch, 3: 2512444-3.patch, failed testing.

MattA’s picture

MattA commented
Status: Needs work » Needs review
StatusFileSize
new 2512444-5.patch702 bytes

OMG windows sucks.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +Quickfix
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice find!

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 17a39ed on 8.0.x 
    Issue #2512444 by MattA: Unused namespaces in EntityDeriver.php

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.