It doesn't look like this function does anything, but doesn't seem worth a patch on its own(?) since it's the dev version.
function panelizer_add_revision_info_form_submit(&$form, &$form_state) {
$entity = $form_state['entity'];
if (!empty($form_state['use revisions'])) {
$entity->revision = $form_state['values']['revision'];
$entity->log = $form_state['values']['log'];
}
}
Proposed solution:
$entity = &$form_state['entity'];
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | panelizer-n2512342-2.patch | 527 bytes | justin.shinn |
| #1 | panelizer-n2512342-1.patch | 616 bytes | damienmckenna |
Comments
Comment #1
damienmckenna@sonfordangeles: Thanks for pointing out the bug. Yes, it's worth adding a patch.
Comment #3
damienmckennaCommitted. Thanks.
Comment #6
justin.shinn commentedI am still getting the following notice when saving(from ID panelizer-edit-content-form) on panelizer content form as a non admin user.
Notice: Undefined index: log in panelizer_add_revision_info_form_submit() (line 227 of /path-to-site/docroot/sites/all/modules/contrib/panelizer/includes/common.inc).
/**
* Form submission callback for panelizer_add_revision_info_form().
*/
function panelizer_add_revision_info_form_submit(&$form, &$form_state) {
$entity = &$form_state['entity'];
if (!empty($form_state['use revisions'])) {
$entity->revision = $form_state['values']['revision'];
$entity->log = isset($form_state['values']['log']) ? $form_state['values']['log'] : "";
}
}
Comment #7
shelaneThis should be open as the issue isn't fixed entirely. The patch Justin Shinn submitted adds another piece to clean this up.