'#title' => ($section['depth'] == 0 ? t('All of') . ' ' : '') . str_repeat('-', $section['depth']) . ' ' . check_plain($section['name']),

The dynamic parts of the string should be inserted with t() placeholders.

CommentFileSizeAuthor
#10 incorrect-t-function-usage-2511376-10.patch823 bytesdmytro-aragorn
#10 workbench_my_sections.jpg65.43 KBdmytro-aragorn
#4 incorrect-t-function-usage-2511376-4.patch2.42 KBpravin ajaaz
#2 incorrect-t-function-usage-2511376-2.patch2.42 KBpravin ajaaz

Comments

joachim’s picture

joachim commented
Title: incorrect use of t() in user sections form » incorrect use of t() in sections forms

Actually, several occurrences of this.

pravin ajaaz’s picture

pravin ajaaz commented
Status: Active » Needs review
StatusFileSize
new incorrect-t-function-usage-2511376-2.patch2.42 KB

Status: Needs review » Needs work

The last submitted patch, 2: incorrect-t-function-usage-2511376-2.patch, failed testing.

pravin ajaaz’s picture

pravin ajaaz commented
StatusFileSize
new incorrect-t-function-usage-2511376-4.patch2.42 KB

Fixed syntax error

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Needs work » Needs review

changing status

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Reviewed & tested by the community

Looks good.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dmytro-aragorn’s picture

dmytro-aragorn
Primary language Ukrainian
Location Lutsk
commented
Status: Closed (fixed) » Needs review
StatusFileSize
new workbench_my_sections.jpg65.43 KB
new incorrect-t-function-usage-2511376-10.patch823 bytes

A list of sections on the 'My sections' page for users without an 'assign workbench access' permission looks badly - "br" tag doesn't do what it should. The reason is in a @string variable in t() which apply a check_plain() function.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Odd.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.